Fix validation #1377
Merged
Fix validation #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
reviewed
Oct 31, 2021
| @@ -491,6 +491,9 @@ | |||
| url: url, | |||
| data: $form.serialize(), | |||
| type: method, | |||
| headers: { | |||
| Accept: 'text/html, application/xhtml+xml;' | |||
| }, | |||
| success: function (resp) { | |||
| $loader.hide(); | |||
| if (resp.result && resp.result === 'ok') { | |||
There was a problem hiding this comment.
If the accepted type is only HTML, how is this condition supposed to work?
There was a problem hiding this comment.
@phansys @VincentLanglet the explanation of the fix was in the original issue #1318 (comment) if you have some question just ask
|
Please review @sonata-project/contributors |
core23
approved these changes
Nov 6, 2021
|
Thanks @VincentLanglet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Similar to #1323
I am targeting this branch, because bugfix.
Closes #1376.
Changelog