PageExtension without deprecated InitRuntimeInterface

[Hanmac]

Subject

I am targeting this branch, because i don't know if that would count as BC.

Closes #{put_issue_number_here}.

it fixes:

The "Sonata\PageBundle\Twig\Extension\PageExtension" class implements "Twig\Extension\InitRuntimeInterface" that is deprecated since Twig 2.7, to be removed in 3.0.

The Thing about $env->getGlobals()['app']->getRequest()->getPathInfo();, my gut is telling me that RequestStack would be cleaner, but that wouldn't be BC anymore if this one might be.

Changelog

### Changed
- PageExtension doesn't need InitRuntimeInterface anymore

[eerison]

@Hanmac can you open to 3.x? we should remove the deprecation from 3.x and merge into 4.x

[Hanmac]

@Hanmac can you open to 3.x? we should remove the deprecation from 3.x and merge into 4.x

@eerison you mean this changes should be BC for 3.x? or do you mean twig 3.x?

[eerison]

@Hanmac can you open to 3.x? we should remove the deprecation from 3.x and merge into 4.x

@eerison you mean this changes should be BC for 3.x? or do you mean twig 3.x?

well because this deprecations are in 3.x, and to upgrade from 3.x to 4.x, the guy need to solve all deprecations and after that he is safe to migrate to next major.

for this reason we should solve the deprecations into the 3.x branch and after that merge into 4.x

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[VincentLanglet]

I disagree with @eerison, this should be done in 4.x.

In 3.x, we only to add deprecation about what will be changed/removed in 4.x about the PageBundle.
But there is no need to solve all the symfony/twig deprecation directly in 3.x. Especially because some of them require BC-break.

Here, not extending/implementing a class/interface is a BC-break. Sure there is almost no chance it will break someone code ; but we should stay with our BC-policy.

The strategy for the user will be the following

• Bump to SonataPage 4.x which will be compatible with Symfony 4 and 5 and Twig 2 and 3.
• Bump to Symfony 5.
• Bump to Twig 3.

[eerison]

hmmm I see, But in this case who uses sonata page bundle 3.x never will solve all deprecations, because some of them are inside of sonata page code.

Then what do you say, is we do not need to care about deprecations in 3.x that was introduced from symfony, just solve them in the next major.

[eerison]

For me it's fine :)

There is a comment that you need to solve 👀

[VincentLanglet]

But in this case who uses sonata page bundle 3.x never will solve all deprecations, because some of them

It's not an issue.
People should just solve direct deprecations, not indirect ones.

[VincentLanglet]

Thanks