Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotManager: use QueryBuilder #1446

Merged
merged 10 commits into from Jul 18, 2022

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jul 12, 2022

Subject

I am targeting this branch, because it should be BC.

Still Draft, i need to update the other queries, and i need to write a functional testcase using KernelTestCase and a Test Database

Closes #{put_issue_number_here}.

Changelog

### Changed
- Updated SnapshotManger to use QueryBuilder instead of native SQL

@Hanmac Hanmac mentioned this pull request Jul 13, 2022
17 tasks
@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 13, 2022

first query is done, one more to go

@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 15, 2022

it seems it doesn't crash on newer doctrine orm, i need to debug that more

@VincentLanglet
Copy link
Member

it seems it doesn't crash on newer doctrine orm, i need to debug that more

You're allowed to bump the doctrine orm version if needed

@Hanmac Hanmac marked this pull request as ready for review July 16, 2022 16:27
VincentLanglet
VincentLanglet previously approved these changes Jul 18, 2022
@VincentLanglet VincentLanglet requested review from jordisala1991 and a team July 18, 2022 07:45
@VincentLanglet VincentLanglet dismissed their stale review July 18, 2022 07:51

Let's clarify what we do about getSingleColumnResult

@eerison
Copy link
Contributor

eerison commented Jul 18, 2022

for me it's fine :) , good job @Hanmac 👏🏼

@eerison
Copy link
Contributor

eerison commented Jul 18, 2022

@Hanmac can you just update your PR's description please! specially the Changelog

VincentLanglet
VincentLanglet previously approved these changes Jul 18, 2022
@VincentLanglet VincentLanglet requested a review from a team July 18, 2022 12:45
jordisala1991
jordisala1991 previously approved these changes Jul 18, 2022
tests/bootstrap.php Outdated Show resolved Hide resolved
@VincentLanglet VincentLanglet merged commit 52a3530 into sonata-project:3.x Jul 18, 2022
@Hanmac Hanmac deleted the snapshotQuery branch July 19, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants