Increase PHPStan to level 2 #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
requested changes
Jul 14, 2022
jordisala1991
force-pushed
the
hotfix/increase-phpstan
branch
from
7cf397b
to
7802fc6
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
hotfix/increase-phpstan
branch
from
7802fc6
to
682c2d4
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
hotfix/increase-phpstan
branch
from
682c2d4
to
06ed757
Compare
jordisala1991
force-pushed
the
hotfix/increase-phpstan
branch
from
dc8ca47
to
ca3747b
Compare
VincentLanglet
previously approved these changes
Jul 17, 2022
|
Good to me (except tests) |
jordisala1991
force-pushed
the
hotfix/increase-phpstan
branch
from
f3de0d5
to
d8e0371
Compare
jordisala1991
force-pushed
the
hotfix/increase-phpstan
branch
from
b2e563e
to
52f96e2
Compare
VincentLanglet
approved these changes
Jul 18, 2022
VincentLanglet
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is for the next major.
Changelog