Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Symfony 5 and 6 #1491

Merged
merged 17 commits into from Jul 26, 2022

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jul 25, 2022

Subject

I am targeting this branch, because this is BC break.

Closes #1410

Changelog

### Added
- Add support for Symfony 5 and 6.

@jordisala1991
Copy link
Member Author

Depends on how hard is fixing the: LogoutHandlerInterface, we might do first 5.4 and then 6.0 or in the same PR.

use Symfony\Component\Security\Http\Logout\LogoutHandlerInterface; used in CmsManagerSelector.

@eerison eerison mentioned this pull request Jul 25, 2022
10 tasks
Comment on lines +51 to +52
* @param int $pageId Page identifier
* @param int $blockId Block identifier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int|string I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im trying to focus only on needed changes for sf 5/6. This will go to a PHPStan up PR.

@jordisala1991
Copy link
Member Author

There is some work to do still.

@jordisala1991 jordisala1991 marked this pull request as ready for review July 25, 2022 17:37
@jordisala1991
Copy link
Member Author

Here the Pr for dev kit: sonata-project/dev-kit#2121

@VincentLanglet VincentLanglet merged commit aa13f97 into sonata-project:4.x Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants