-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom url #1607
Fix custom url #1607
Conversation
4075987
to
f8cc118
Compare
Could you please rebase your PR and fix merge conflicts? |
Does a test should be added ? You generally add a test which is failing yhe ci then yiu fix the bug. Here you changed the code (failing the ci) then you fixed the test. Does it mean test was wrong ? |
code changed behavior, that's why test was wrong. I will try to see if a test can be added, but not sure it is easy. |
435dba9
to
a0be0fc
Compare
Test added, both for pages and snapshots, @VincentLanglet . The thing is: the URL is not editable by the user. The user can only add pages being child of other pages, with a hierarchy like:
The other field you can change is the customURL, that way the url will be whatever you place on that field, like: '/test1/test2/test3', without the need of the full hierarchy. Also this field is only usable on CMS pages, NOT hybrid or dynamic (those pages fixes the url through symfony routing). IMO it makes sense to keep using everywhere the url field. there was another PR proposing to do some match between url and custom url, but that complicates things IMO. The only thing that was taken into account is the relativePath of the SITE |
Subject
I am targeting this branch, because this is a bug fix.
Closes #502
Changelog