Support list_action_button_content in buttons #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
approved these changes
Mar 10, 2023
|
Or maybe a minor, but will need the dev-kit PR merged first (or we might not care, but it needs it to release) |
VincentLanglet
approved these changes
Mar 10, 2023
I would say it's ok to merge this. |
|
Thank you @gremo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is a minor fix. The setting
list_action_button_contentexists since SonataAdmin 3.x. as well assonata_configglobal Twig variable.Feel free to change the icon (not present before this PR) for the "create publications" button. I've chosen the fa-upload icon.
Closes #1659
Changelog