Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use font-awesome icon instead of a famfamfam icon #787

Merged
merged 1 commit into from Feb 21, 2017
Merged

use font-awesome icon instead of a famfamfam icon #787

merged 1 commit into from Feb 21, 2017

Conversation

OskarStark
Copy link
Member

@OskarStark OskarStark commented Feb 21, 2017 •
edited

I am targetting this branch, because this is BC.

Refs sonata-project/SonataAdminBundle#4315

Changelog

### Changed
- use font awesome icon instead of famfamfam icon in `select_site.html.twig`

@OskarStark OskarStark mentioned this pull request Feb 21, 2017
Merged
@OskarStark
Copy link
Member Author

reworded the commit msg

@OskarStark
use font-awesome icon instead of a famfamfam icon
a9721dc 
we will remove the famfamfam icon set from the admin bundle
@greg0ire greg0ire merged commit abc734c into sonata-project:3.x Feb 21, 2017
@greg0ire
Copy link
Contributor

Thanks @OskarStark !

@OskarStark OskarStark deleted the famfamfam-remove branch February 22, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@core23 core23 core23 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OskarStark @greg0ire @core23 @SonataCI