Cast metadata to string

sonata-project · Feb 13, 2019 · b73bf69 · b73bf69
1 parent 4ccd5b6
commit b73bf69
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/Twig/Extension/SeoExtension.php b/src/Twig/Extension/SeoExtension.php
@@ -262,6 +262,6 @@ public function getOembedLinks()
      */
     private function normalize($string)
     {
-        return htmlentities(strip_tags($string), ENT_COMPAT, $this->encoding);
+        return htmlentities(strip_tags((string) $string), ENT_COMPAT, $this->encoding);
     }
 }
diff --git a/tests/Twig/Extension/SeoExtensionTest.php b/tests/Twig/Extension/SeoExtensionTest.php
@@ -85,13 +85,16 @@ public function testMetadatas()
             'name' => ['foo' => ['bar "\'"', []]],
             'schema' => [],
             'charset' => ['UTF-8' => ['', []]],
-            'property' => [],
+            'property' => [
+                'og:image:width' => [848, []],
+                'og:type' => [new MetaTest(), []],
+            ],
         ]));
 
         $extension = new SeoExtension($page, 'UTF-8');
 
         $this->assertSame(
-            "<meta name=\"foo\" content=\"bar &quot;'&quot;\" />\n<meta charset=\"UTF-8\" />\n",
+            "<meta name=\"foo\" content=\"bar &quot;'&quot;\" />\n<meta charset=\"UTF-8\" />\n<meta property=\"og:image:width\" content=\"848\" />\n<meta property=\"og:type\" content=\"article\" />\n",
             $extension->getMetadatas()
         );
     }
@@ -147,3 +150,11 @@ public function testOEmbedLinks()
         );
     }
 }
+
+class MetaTest
+{
+    public function __toString()
+    {
+        return 'article';
+    }
+}