Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs #288

Merged
merged 1 commit into from Nov 2, 2018
Merged

Updated docs #288

merged 1 commit into from Nov 2, 2018

Conversation

core23
Copy link
Member

@core23 core23 commented Nov 2, 2018

I am targeting this branch, because this is related to the docs.

Subject

Just a doc update

@core23 core23 added the docs label Nov 2, 2018
@core23 core23 requested a review from a team November 2, 2018 07:20

<?php

$seoPage = $this->container->get('sonata.seo.page');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention DI instead of container get here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an addition to the paragraph before

@OskarStark OskarStark merged commit 348c6b7 into sonata-project:2.x Nov 2, 2018
@core23 core23 deleted the patch/docs branch November 2, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants