Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #416

Merged
merged 1 commit into from Aug 27, 2020
Merged

Fix build #416

merged 1 commit into from Aug 27, 2020

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Not the perfect solution, but this allow the build to pass:

composer/composer#9157

Changelog

### Removed
- Support for `sonata-project/exporter` < 2.0

@jordisala1991 jordisala1991 requested a review from a team August 27, 2020 17:00
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #416 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #416   +/-   ##
=========================================
  Coverage     35.39%   35.39%           
  Complexity      210      210           
=========================================
  Files            26       26           
  Lines           904      904           
=========================================
  Hits            320      320           
  Misses          584      584           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937317...0fed7b2. Read the comment docs.

@greg0ire greg0ire merged commit 9806da3 into sonata-project:2.x Aug 27, 2020
@greg0ire
Copy link
Contributor

Thanks @jordisala1991 !

@jordisala1991 jordisala1991 deleted the hotfix/fix-build branch August 27, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants