Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumb rendering #620

Merged
merged 2 commits into from Nov 1, 2021
Merged

Fix breadcrumb rendering #620

merged 2 commits into from Nov 1, 2021

Conversation

core23
Copy link
Member

@core23 core23 commented Nov 1, 2021 •
edited by phansys

Subject

The execute method was missing, so the breadcrumb was rendered as an empty block.

This is basically a soft-port of https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php.

I am targeting this branch, because this is a patch for the next stable release.

Changelog

### Changed
- Mark `BaseBreadcrumbMenuBlockService::getRootMenu()` as final

### Fixed
- Fixed breadcrumb rendering

@core23 core23 added the patch label Nov 1, 2021
@core23 core23 requested a review from a team November 1, 2021 14:42
@core23
Copy link
Member Author

core23 commented Nov 1, 2021

Same as #619, but targeting the right branch

@core23 core23 merged commit 9f3287a into sonata-project:3.x Nov 1, 2021
@core23 core23 deleted the fix-menu branch November 1, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@core23 @phansys @VincentLanglet