This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Removed deprecations #112
Merged
Removed deprecations #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Mar 3, 2017
greg0ire
approved these changes
Mar 3, 2017
Admin/AdminExtension.php
Outdated
| */ | ||
| public function __construct(ActionManagerInterface $actionManager, SecurityContextInterface $securityContext) | ||
| public function __construct(ActionManagerInterface $actionManager, TokenStorageInterface $securityContext) |
There was a problem hiding this comment.
I think you should not type hint this.
Admin/AdminExtension.php
Outdated
| * @param ActionManagerInterface $actionManager | ||
| * @param SecurityContextInterface $securityContext | ||
| * @param ActionManagerInterface $actionManager | ||
| * @param TokenStorageInterface $securityContext |
There was a problem hiding this comment.
This is SecurityContextInterface|TokenStorageInterface
|
Can you review again @jordisala1991 ? |
jordisala1991
approved these changes
Mar 10, 2017
|
Thanks @core23 ! |
core23
added a commit
to core23/SonataTimelineBundle
that referenced
this pull request
Mar 24, 2017
Merged
jordisala1991
added a commit
that referenced
this pull request
Mar 30, 2017
|
@core23 please look at the changelog update. The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because this is a bugfix.
Changelog
Subject
Removed symfony and internal deprecation.