This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Remove SonataIntlBundle dependency #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no usage in Twig templates too? |
franmomu
changed the title
You're right 😟 |
franmomu
force-pushed
the
remove_intl_bundle
branch
from
5e089bd
to
f5be31d
Compare
core23
reviewed
Dec 20, 2019
core23
suggested changes
Dec 20, 2019
src/Resources/config/twig.xml
Outdated
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
| <services> | ||
| <service id="sonata.timeline.twig.intl_extension" class="Twig\Extensions\IntlExtension"> |
There was a problem hiding this comment.
When I've used them in a project, I had to add them as services. In the docs it says:
use Twig\Extra\Intl\IntlExtension;
$twig = new \Twig\Environment(...);
$twig->addExtension(new IntlExtension());which I haven't check but I guess is what twig.extension tag does.
There was a problem hiding this comment.
Okay then. We could keep this for the stable release to stay BC. We should remove this service and update the installation instruction for the next major release.
franmomu
force-pushed
the
remove_intl_bundle
branch
from
f5be31d
to
4c4503e
Compare
core23
previously approved these changes
Dec 20, 2019
franmomu
force-pushed
the
remove_intl_bundle
branch
from
4c4503e
to
d436de5
Compare
franmomu
changed the title
franmomu
changed the title
|
Could you please rebase your PR and fix merge conflicts? |
franmomu
force-pushed
the
remove_intl_bundle
branch
from
d436de5
to
76f3706
Compare
|
Since the minimum is now |
OskarStark
approved these changes
Feb 29, 2020
|
Ups |
core23
approved these changes
Feb 29, 2020
phansys
approved these changes
Feb 29, 2020
|
Thanks @franmomu ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Ref sonata-project/SonataIntlBundle#280
I am targeting this branch, because this is BC.
Changelog