We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using GlobalSearch, filters are built with OR condition:
if ($filter->getOption('global_search', false)) { $filter->setCondition(FilterInterface::CONDITION_OR); $datagrid->setValue($filter->getFormName(), null, $term); $found = true; }
however, TranslationFieldFilter applies andWhere explicitly: https://github.com/sonata-project/SonataTranslationBundle/blob/2.x/src/Filter/TranslationFieldFilter.php#L56
It should respect $condition and act accordingly. Should I PR that?
The text was updated successfully, but these errors were encountered:
Make TranslationFieldFilter respect condition
72eb296
Make TranslationFieldFilter respect condition, fixes global search on translatable fields. Fixes #240
Successfully merging a pull request may close this issue.
Subject
When using GlobalSearch, filters are built with OR condition:
however, TranslationFieldFilter applies andWhere explicitly: https://github.com/sonata-project/SonataTranslationBundle/blob/2.x/src/Filter/TranslationFieldFilter.php#L56
It should respect $condition and act accordingly. Should I PR that?
The text was updated successfully, but these errors were encountered: