Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close api #425

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Close api #425

merged 2 commits into from
Dec 9, 2020

Conversation

franmomu
Copy link
Member

Subject

This PR make classes final that were marked as so and adds type declarations.

I am targeting this branch, because this is BC break.

Changelog

### Changed
- Added `final` modifier to classes.
- Reduced visibility of methods and properties.
- Added type declarations.

@franmomu franmomu added the major label Nov 20, 2020
VincentLanglet
VincentLanglet reviewed Nov 20, 2020
View reviewed changes
src/Admin/Extension/Gedmo/TranslatableAdminExtension.php Outdated
* @return TranslatableListener
*/
protected function getTranslatableListener(AdminInterface $admin)
private function getTranslatableListener(): TranslatableListener
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the interest of this method ?
Why not using $this->translatableListener; directly ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I didn't notice

VincentLanglet
VincentLanglet previously approved these changes Nov 21, 2020
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team November 21, 2020 16:02
@franmomu
Resolve NEXT_MAJOR comments
f6dea80
@franmomu
Close API
2c113ec 
This makes classes final that were marked as final previously
and changes the scope from protected to private in those classes.

It also adds some type declarations.
@VincentLanglet VincentLanglet requested a review from a team November 27, 2020 08:28
@OskarStark OskarStark merged commit eb65921 into sonata-project:master Dec 9, 2020
@franmomu franmomu deleted the close_api branch December 9, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franmomu @OskarStark @VincentLanglet