Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Already logged in checks #627

Closed
sagikazarmark opened this issue Sep 28, 2015 · 2 comments
Closed

Already logged in checks #627

sagikazarmark opened this issue Sep 28, 2015 · 2 comments
Labels
pending author

Comments

@sagikazarmark
Copy link
Contributor

Currently login checks are done the following way: The token is fetched from the SecurityContext and if it is an instance of UserInterface (from FOSUserBundle).

The most common way is to check the security context for the role IS_FULLY_AUTHENTICATED.

In some cases it might worth to check if the Token holds an instance of UserInterface, but in most cases I don't think it is necessary, checking the special login role is enough.

/cc @rande
@core23
Copy link
Member

core23 commented Aug 27, 2016

Can you provide a PR @sagikazarmark ?

@jordisala1991 jordisala1991 mentioned this issue Apr 23, 2017
Merged
4 tasks
@OskarStark
Copy link
Member

Closed via #869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OskarStark @sagikazarmark @core23