Add configuration for Test Kernel

sonata-project · Jan 4, 2022 · 3104010 · 3104010
1 parent 992e513
commit 3104010
Show file tree

Hide file tree

Showing 8 changed files with 45 additions and 1 deletion.
diff --git a/config/projects.yaml b/config/projects.yaml
@@ -76,6 +76,7 @@ admin-bundle:
                 sonata-project/block-bundle: ['3.*']
 
 block-bundle:
+    has_test_kernel: false
     branches:
         5.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -91,6 +92,7 @@ block-bundle:
                 symfony/symfony: ['4.4.*']
 
 cache:
+    has_test_kernel: false
     phpstan: false
     psalm: false
     excluded_files:
@@ -103,6 +105,7 @@ cache:
             php: ['7.3', '7.4', '8.0', '8.1']
 
 cache-bundle:
+    has_test_kernel: false
     branches:
         4.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -134,6 +137,7 @@ classification-bundle:
                 symfony/symfony: ['4.4.*']
 
 datagrid-bundle:
+    has_test_kernel: false
     branches:
         4.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -192,6 +196,7 @@ entity-audit-bundle:
     excluded_files:
         - README.md
     has_documentation: false
+    has_test_kernel: false
     branches:
         2.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -206,6 +211,7 @@ entity-audit-bundle:
 
 exporter:
     documentation_badge_slug: sonata-project-exporter
+    has_test_kernel: false
     branches:
         3.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -220,6 +226,7 @@ exporter:
 
 formatter-bundle:
     psalm: false
+    has_test_kernel: false
     branches:
         5.x:
             php: ['7.4', '8.0', '8.1']
@@ -235,6 +242,7 @@ formatter-bundle:
                 sonata-project/block-bundle: ['3.*']
 
 form-extensions:
+    has_test_kernel: false
     branches:
         2.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -251,13 +259,15 @@ google-authenticator:
     excluded_files:
         - README.md
     has_documentation: false
+    has_test_kernel: false
     branches:
         3.x:
             php: ['7.3', '7.4', '8.0', '8.1']
         2.x:
             php: ['7.3', '7.4', '8.0', '8.1']
 
 intl-bundle:
+    has_test_kernel: false
     branches:
         3.x:
             php: ['7.3', '7.4', '8.0', '8.1']
@@ -293,6 +303,7 @@ media-bundle:
 notification-bundle:
     custom_doctor_rst_whitelist_part:
         "    - 'resource: \"@NelmioApiDocBundle/Resources/config/routing.yml\"'"
+    has_test_kernel: false
     branches:
         4.x:
             php: ['7.3', '7.4', '8.0']
@@ -319,6 +330,7 @@ page-bundle:
                 sonata-project/block-bundle: ['3.*']
 
 seo-bundle:
+    has_test_kernel: false
     branches:
         4.x:
             php: ['7.4', '8.0', '8.1']

diff --git a/src/Command/Dispatcher/DispatchBranchesProtectionCommand.php b/src/Command/Dispatcher/DispatchBranchesProtectionCommand.php
@@ -167,6 +167,13 @@ private function buildRequiredStatusChecks(Project $project, Branch $branch): ar
             $requiredStatusChecks[] = 'Webpack Encore';
         }
 
+        if ($project->hasTestKernel()) {
+            $requiredStatusChecks[] = 'Symfony container';
+            $requiredStatusChecks[] = 'Twig files';
+            $requiredStatusChecks[] = 'XLIFF files';
+            $requiredStatusChecks[] = 'YML files';
+        }
+
         /** @var PhpVersion $phpVersion */
         foreach ($branch->phpVersions() as $phpVersion) {
             $requiredStatusChecks[] = sprintf(

diff --git a/src/Command/Dispatcher/DispatchFilesCommand.php b/src/Command/Dispatcher/DispatchFilesCommand.php
@@ -287,6 +287,11 @@ private function deleteNotNeededFilesAndDirs(Project $project, Branch $branch, s
             $filesToRemove[] = '.symfony.bundle.yaml';
         }
 
+        if (!$project->hasTestKernel()) {
+            $filesToRemove[] = 'bin/console';
+            $filesToRemove[] = '.github/workflows/symfony-lint.yaml';
+        }
+
         foreach ($filesToRemove as $fileToRemove) {
             $file = u($distPath)
                 ->append('/')

diff --git a/src/Config/ProjectsConfiguration.php b/src/Config/ProjectsConfiguration.php
@@ -42,6 +42,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                             ->scalarNode('custom_gitattributes_part')->defaultNull()->end()
                             ->scalarNode('custom_doctor_rst_whitelist_part')->defaultNull()->end()
                             ->booleanNode('has_documentation')->defaultTrue()->end()
+                            ->booleanNode('has_test_kernel')->defaultTrue()->end()
                             ->scalarNode('documentation_badge_slug')->defaultNull()->end()
                             ->arrayNode('branches')
                                 ->normalizeKeys(false)

diff --git a/src/Domain/Value/Project.php b/src/Domain/Value/Project.php
@@ -43,6 +43,7 @@ final class Project
     private array $phpunitExtensions;
 
     private bool $hasDocumentation;
+    private bool $hasTestKernel;
     private bool $phpstan;
     private bool $psalm;
     private ?string $customGitignorePart;
@@ -59,6 +60,7 @@ private function __construct(
         array $excludedFiles,
         array $phpunitExtensions,
         bool $hasDocumentation,
+        bool $hasTestKernel,
         bool $phpstan,
         bool $psalm,
         ?string $customGitignorePart,
@@ -73,6 +75,7 @@ private function __construct(
         $this->package = $package;
         $this->branches = $branches;
         $this->hasDocumentation = $hasDocumentation;
+        $this->hasTestKernel = $hasTestKernel;
         $this->phpstan = $phpstan;
         $this->psalm = $psalm;
         $this->excludedFiles = $excludedFiles;
@@ -109,6 +112,7 @@ public static function fromValues(string $name, array $config, Package $package)
             $excludedFiles,
             $phpunitExtensions,
             $config['has_documentation'],
+            $config['has_test_kernel'],
             $config['phpstan'],
             $config['psalm'],
             $config['custom_gitignore_part'],
@@ -225,6 +229,11 @@ public function hasDocumentation(): bool
         return $this->hasDocumentation;
     }
 
+    public function hasTestKernel(): bool
+    {
+        return $this->hasTestKernel;
+    }
+
     public function usesPHPStan(): bool
     {
         return $this->phpstan;

diff --git a/templates/project/.github/workflows/symfony-lint.yaml.twig b/templates/project/.github/workflows/symfony-lint.yaml.twig
@@ -91,7 +91,7 @@ jobs:
               run: bin/console lint:xliff src tests --format=github
 
     yaml:
-        name: YAML files
+        name: YML files
 
         runs-on: ubuntu-latest
 

diff --git a/tests/Command/Dispatcher/DispatchFilesCommandTest.php b/tests/Command/Dispatcher/DispatchFilesCommandTest.php
@@ -80,6 +80,7 @@ public function projectProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master:

diff --git a/tests/Domain/Value/ProjectTest.php b/tests/Domain/Value/ProjectTest.php
@@ -31,6 +31,7 @@ final class ProjectTest extends TestCase
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master:
@@ -94,6 +95,7 @@ public function valid(): void
         static::assertNull($project->customGitignorePart());
         static::assertNull($project->customGitattributesPart());
         static::assertTrue($project->hasDocumentation());
+        static::assertTrue($project->hasTestKernel());
         static::assertTrue($project->isBundle());
     }
 
@@ -138,6 +140,7 @@ public function isBundleProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: 'sonataadminbundle2'
   branches:
     master:
@@ -167,6 +170,7 @@ public function isBundleProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master:
@@ -457,6 +461,7 @@ public function documentationBadgeSlugProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master:
@@ -485,6 +490,7 @@ public function documentationBadgeSlugProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: 'sonataadminbundle2'
   branches:
     master:
@@ -543,6 +549,7 @@ public function defaultBranchProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master:
@@ -571,6 +578,7 @@ public function defaultBranchProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master:
@@ -610,6 +618,7 @@ public function defaultBranchProvider(): iterable
   custom_gitattributes_part: ~
   custom_doctor_rst_whitelist_part: ~
   has_documentation: true
+  has_test_kernel: true
   documentation_badge_slug: ~
   branches:
     master: