Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psalm to sonata-project/doctrine-mongodb-admin-bundle #1177

Merged
merged 1 commit into from Oct 29, 2020

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Oct 14, 2020

Ref: sonata-project/SonataDoctrineMongoDBAdminBundle#446

EDIT: looks like the mongodb extension should be installed, I'll take a look later today.

@franmomu franmomu marked this pull request as draft October 14, 2020 06:46
@franmomu
Copy link
Member Author

We cannot run psalm in the packages which need php extensions not installed by default... should we just use psalm directly since it's in the dev requirements instead of the https://github.com/psalm/psalm-github-actions?

@franmomu franmomu marked this pull request as ready for review October 29, 2020 09:21
@OskarStark OskarStark merged commit 8233d76 into sonata-project:master Oct 29, 2020
@franmomu franmomu deleted the add_psalm_mongodb branch October 29, 2020 16:54
OskarStark added a commit that referenced this pull request Oct 29, 2020
* master: (35 commits)
  Fix: Conclusion can be null (#1227)
  Add psalm to sonata-project/doctrine-mongodb-admin-bundle (#1177)
  Enhancement: Use specific ubuntu version (#1226)
  Enhancement: Mark (PHP 8.0 + highest + normal) always successful (#1202)
  Fix blank line (#1225)
  Fix indention
  Remove matrix
  Restrict to targeted php version
  Stop using custom action for static analysis
  Fix indent
  Build(deps): Bump symfony/string from 5.1.7 to 5.1.8 (#1223)
  Build(deps-dev): Bump symfony/web-profiler-bundle from 5.1.7 to 5.1.8 (#1222)
  Build(deps): Bump symfony/http-client from 5.1.7 to 5.1.8 (#1217)
  Build(deps): Bump symfony/yaml from 5.1.7 to 5.1.8 (#1216)
  Build(deps-dev): Bump symfony/phpunit-bridge from 5.1.7 to 5.1.8 (#1218)
  Build(deps-dev): Bump symfony/debug-bundle from 5.1.7 to 5.1.8 (#1221)
  Build(deps-dev): Bump symfony/stopwatch from 5.1.7 to 5.1.8 (#1219)
  Build(deps): Bump symfony/framework-bundle from 5.1.7 to 5.1.8 (#1220)
  Build(deps): Bump symfony/dotenv from 5.1.7 to 5.1.8 (#1215)
  Build(deps): Bump symfony/console from 5.1.7 to 5.1.8 (#1214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants