This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Remove internal test classes from autoloader #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,3 +4,7 @@ UPGRADE FROM 1.x to 2.0 | |||
| ### Sonata dependencies | |||
|
|
|||
| Bump all Sonata dependencies to versions managed by the new management system. | |||
|
|
|||
| ### Tests | |||
There was a problem hiding this comment.
Should not be here but on 2.x upgrade file.
core23
force-pushed
the
patch/autoload-dev
branch
from
7def83a
to
646370a
Compare
|
LGTM for me. ping @sonata-project/contributors for a second and final review. |
|
|
||
| ### Tests | ||
|
|
||
| All files under the ``Tests`` directory are now correctly handled as internal test classes. You can't extend them anymore, because they are only loaded when running internal tests. More information can be found in the [composer docs](https://getcomposer.org/doc/04-schema.md#autoload-dev). |
core23
force-pushed
the
patch/autoload-dev
branch
from
646370a
to
31c5ecf
Compare
|
LGTM 👍 |
|
Thanks @core23 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because test classes shouldn't be used by anybody.
This is a copy of the #383 but targets the 2.x branch.
Related to sonata-project/dev-kit#179
Changelog
Subject
Tests for internal components shouldn't be loaded in production or extended by other bundles.