This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
fix block deprecated method #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👌🏻 |
This was referenced Aug 18, 2016
|
@soullivaneuh stuck build |
| @@ -59,7 +59,7 @@ public function getName() | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function setDefaultSettings(OptionsResolverInterface $resolver) | |||
| public function configureSettings(OptionsResolver $resolver) | |||
There was a problem hiding this comment.
this is a BC break, isn't it?
There was a problem hiding this comment.
no as the current code does not work...
|
Can we merge this PR ? |
|
No b/c the build is stuck. Let's ask @soullivaneuh |
|
Thanks @rande |
|
HI, I am using e-commerce version 2.1.1 but my basket page and single product page is empty. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because there it is the latest one :)
Fixes #386
Changelog
Subject
There is a regression with the method called by BlockContextManager. Only
configureSettingsmethods are being called.