Use new datepicker #575
Use new datepicker #575
Conversation
|
@pierredup @core23 squashed. |
| if ($container->hasExtension('twig')) { | ||
| // add custom form widgets | ||
| $container->prependExtensionConfig('twig', ['form_themes' => ['@SonataCore/Form/datepicker.html.twig']]); | ||
| } |
There was a problem hiding this comment.
Why is the PR not backwards compatible and why is this necessary now, and was not before?
There was a problem hiding this comment.
I guess it ís backwards compatible (I've rebased).
Without this, the input used is just a normal text input. Am I missing something or do I add this fragment to Sonata\OrderBundle\DependencyInjection\SonataOrderExtension so the bundles can be used separately?
There was a problem hiding this comment.
You can do that yeah. Since it is BC, maybe contribute it to the stable branch then?
There was a problem hiding this comment.
Was a bit confused but had to change the base branch here. (instead of rebasing in git 🤦♂)
There was a problem hiding this comment.
I think you would have to do both things :P
quisse
force-pushed
the
datepicker-fix
branch
from
c442f44
to
eada18f
Compare
|
Thanks @quisse ! |
Subject
I am targeting this branch, because not backwards compatible.
Changelog