Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Master - make order steps working on front office for symfony 4.1 - PR 2 #603

Merged
merged 1 commit into from Nov 9, 2019
Merged

Master - make order steps working on front office for symfony 4.1 - PR 2 #603

merged 1 commit into from Nov 9, 2019

Conversation

salamichel
Copy link
Contributor

@salamichel salamichel commented Oct 6, 2019

Subject

Make the order process working on front for symfony >4.1.

Closes #601 #610

Changelog

### Changed
- inject alias 'sonata.basket.factory' into basket controller
- change  'Free delivery' to 'free_address_required' in accordance with documentation https://sonata-project.org/bundles/ecommerce/master/doc/reference/bundles/delivery.html

@salamichel salamichel marked this pull request as ready for review October 6, 2019 13:22
@salamichel
Copy link
Contributor Author

@greg0ire Hi, could you please review ? the travis issue is regarding xml lint i don't understand what's wrong. rgds

@greg0ire
Copy link
Contributor

greg0ire commented Oct 7, 2019

You can get some help from FlintCI. Click on Details on the FlintCI line, click the "Download raw diff" button, and apply it with patch -p0. I will give you more hints on the changes tab.

@salamichel
Copy link
Contributor Author

@greg0ire Hi, thank you for the explanation, it's very sensitive ;), it's should be OK now but travis won't start testing.

src/BasketBundle/Controller/BasketController.php Outdated Show resolved Hide resolved
src/BasketBundle/Controller/BasketController.php Outdated Show resolved Hide resolved
pierredup
pierredup previously approved these changes Oct 12, 2019
@core23 core23 merged commit fbaedba into sonata-project:master Nov 9, 2019
@core23
Copy link
Member

core23 commented Nov 9, 2019

Thanks @salamichel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants