This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
@salamichel @greg0ire @core23 It is ready to review. |
5 tasks
core23
suggested changes
Dec 31, 2019
@core23 thanks, for you are patient for me. I just get to know how to write good, public code. |
core23
suggested changes
Jan 2, 2020
I add |
65e3415
to
4fc8682
Compare
core23
previously approved these changes
Jan 2, 2020
greg0ire
reviewed
Jan 2, 2020
greg0ire
reviewed
Jan 2, 2020
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. How to do that?
|
17c7134
to
2b2f085
Compare
@greg0ire thanks for rebase example. |
greg0ire
previously approved these changes
Jan 2, 2020
franmomu
reviewed
Jan 2, 2020
franmomu
reviewed
Jan 2, 2020
franmomu
reviewed
Jan 2, 2020
Update UPGRADE-3.x.md Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update src/CustomerBundle/Block/ProfileMenuBlockService.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update src/CustomerBundle/Block/ProfileMenuBlockService.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update src/CustomerBundle/Block/ProfileMenuBlockService.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update src/CustomerBundle/Menu/ProfileMenuBuilder.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update tests/CustomerBundle/Menu/ProfileMenuBuilderTest.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update tests/CustomerBundle/Controller/CustomerControllerTest.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update profile descriptions Update src/CustomerBundle/DependencyInjection/Configuration.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update src/CustomerBundle/DependencyInjection/Configuration.php Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr> Update src/CustomerBundle/Twig/GlobalVariables.php Co-Authored-By: Fran Moreno <franmomu@gmail.com> Update test
a9534b2
to
279ec46
Compare
core23
approved these changes
Jan 3, 2020
franmomu
approved these changes
Jan 3, 2020
Thanks @wbloszyk ! |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR copy part of profile functionality from SonataUserBundle, becouse it was drop in 4.0 version. I changed some code and added extra configuration like template and menu_builder. This change will fix #547 issue and allow easy intagrate with other profile.
I am targeting this branch, because this PR add features.
Closes #547
Changelog