Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Remove mapping from product collection to generic Collection Entity #653

Merged

Conversation

jeroendk
Copy link
Contributor

@jeroendk jeroendk commented Feb 13, 2020

Remove mapping to Classification\Collection to stop forcing people to add an extra property to their generic Collection class.

I am targeting this branch, because (I think) this is a bugfix. not sure though... Some people might actually rely on the association being there? For our use case, it is a bug.

Another option would be to check if the productCollection property exists in the Collection class and if so add the association? We could remove the association altogether in a new major? I would like one's input on this.

Closes #644

Changelog

### Fixed
- Only add association mapping from ProductCollection to Collection when property exists
- Only add inversed side definition in ProductionCollection mapping when property exists. 

quisse
quisse previously approved these changes Feb 13, 2020
@greg0ire greg0ire added the patch label Feb 14, 2020
@greg0ire greg0ire merged commit 5b89467 into sonata-project:3.x Feb 15, 2020
@greg0ire
Copy link
Contributor

Thanks @jeroendk !

@jeroendk jeroendk deleted the bugfix/product-collection-mapping branch February 15, 2020 19:51
@jeroendk
Copy link
Contributor Author

@greg0ire What is your release cycle for the Ecommerce bundle / when can I expect a release with this fix?

@wbloszyk
Copy link
Member

@jeroendk
Can u look at this sandbox#620 ?
Also can you check the same thing like here with User-Customers relation?

@jeroendk
Copy link
Contributor Author

@wbloszyk sure, where can I find the User-Customers relation (discussion)?

@greg0ire
Copy link
Contributor

@greg0ire What is your release cycle for the Ecommerce bundle / when can I expect a release with this fix?

People like you ask me and I release. Expect one for tonight.

@jeroendk
Copy link
Contributor Author

People like you ask me and I release. Expect one for tonight.

Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing property error ($productCollection) caused by the ProductExtension
4 participants