This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 139
Remove mapping from product collection to generic Collection Entity #653
Merged
greg0ire
merged 5 commits into
sonata-project:3.x
from
jeroendk:bugfix/product-collection-mapping
Feb 15, 2020
Merged
Remove mapping from product collection to generic Collection Entity #653
greg0ire
merged 5 commits into
sonata-project:3.x
from
jeroendk:bugfix/product-collection-mapping
Feb 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quisse
previously approved these changes
Feb 13, 2020
greg0ire
reviewed
Feb 14, 2020
5393c60
to
1f1ed5e
Compare
greg0ire
approved these changes
Feb 15, 2020
quisse
approved these changes
Feb 15, 2020
Thanks @jeroendk ! |
@greg0ire What is your release cycle for the Ecommerce bundle / when can I expect a release with this fix? |
@jeroendk |
@wbloszyk sure, where can I find the User-Customers relation (discussion)? |
People like you ask me and I release. Expect one for tonight. |
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mapping to Classification\Collection to stop forcing people to add an extra property to their generic Collection class.
I am targeting this branch, because (I think) this is a bugfix. not sure though... Some people might actually rely on the association being there? For our use case, it is a bug.
Another option would be to check if the productCollection property exists in the Collection class and if so add the association? We could remove the association altogether in a new major? I would like one's input on this.
Closes #644
Changelog