Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Allow "friendsofsymfony/rest-bundle:^3.0" #688

Merged
merged 1 commit into from Sep 2, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Jul 24, 2020

Subject

Allow "friendsofsymfony/rest-bundle:^3.0".

I am targeting this branch, because these changes respect BC.

Changelog

### Added
- support for "friendsofsymfony/rest-bundle:^3.0"
### Changed
- support for deprecated "rest" routing type in favor for xml

phansys
phansys previously approved these changes Aug 18, 2020
@phansys phansys requested a review from a team August 18, 2020 12:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #688 into 3.x will not change coverage.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x     #688   +/-   ##
=========================================
  Coverage     45.33%   45.33%           
  Complexity     2500     2500           
=========================================
  Files           191      191           
  Lines          8127     8127           
=========================================
  Hits           3684     3684           
  Misses         4443     4443           
Impacted Files Coverage Δ Complexity Δ
...InvoiceBundle/Controller/Api/InvoiceController.php 84.00% <ø> (ø) 10.00 <0.00> (ø)
src/OrderBundle/Controller/Api/OrderController.php 84.00% <ø> (ø) 10.00 <0.00> (ø)
...ustomerBundle/Controller/Api/AddressController.php 86.27% <50.00%> (ø) 18.00 <0.00> (ø)
...stomerBundle/Controller/Api/CustomerController.php 88.40% <50.00%> (ø) 24.00 <0.00> (ø)
...ProductBundle/Controller/Api/ProductController.php 88.00% <50.00%> (ø) 26.00 <0.00> (ø)
...c/BasketBundle/Controller/Api/BasketController.php 83.06% <60.00%> (ø) 39.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a52f6...d8ed128. Read the comment docs.

@wbloszyk
Copy link
Member Author

wbloszyk commented Sep 1, 2020

@sonata-project/contributors Can you check it?

Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have some tests covering these routes.

@wbloszyk wbloszyk requested a review from a team September 2, 2020 10:31
@wbloszyk
Copy link
Member Author

wbloszyk commented Sep 2, 2020

I will add it at the end, after add support for nelmio/api-doc-bundle v3

@wbloszyk wbloszyk closed this Sep 2, 2020
@wbloszyk wbloszyk reopened this Sep 2, 2020
@wbloszyk
Copy link
Member Author

wbloszyk commented Sep 2, 2020

@OskarStark Can you look at DOCtor-RTS? You make somethig simmilar (to this), where nelmio/api-doc work with .yml.

@wbloszyk wbloszyk merged commit fda644d into sonata-project:3.x Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants