Skip to content

Commit

Permalink
DevKit updates for 1.x branch (#363)
Browse files Browse the repository at this point in the history
* DevKit updates

* DevKit updates

* Fix phpstan

Co-authored-by: Vincent Langlet <vincentlanglet@hotmail.fr>
  • Loading branch information
SonataCI and VincentLanglet committed May 29, 2022
1 parent 43f2b51 commit 0898fa7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/test.yaml
Expand Up @@ -47,11 +47,6 @@ jobs:
allowed-to-fail: false
symfony-require: 4.4.*
variant: symfony/symfony:"4.4.*"
- php-version: '8.1'
dependencies: highest
allowed-to-fail: false
symfony-require: 5.3.*
variant: symfony/symfony:"5.3.*"
- php-version: '8.1'
dependencies: highest
allowed-to-fail: false
Expand All @@ -62,6 +57,11 @@ jobs:
allowed-to-fail: false
symfony-require: 6.0.*
variant: symfony/symfony:"6.0.*"
- php-version: '8.1'
dependencies: highest
allowed-to-fail: false
symfony-require: 6.1.*
variant: symfony/symfony:"6.1.*"

steps:
- name: Checkout
Expand Down
1 change: 0 additions & 1 deletion .php-cs-fixer.dist.php
Expand Up @@ -64,7 +64,6 @@
'static_lambda' => true,
'strict_comparison' => true,
'strict_param' => true,
'types_spaces' => ['space' => 'single'],
'void_return' => false,
];

Expand Down
4 changes: 2 additions & 2 deletions src/EventListener/ResizeFormListener.php
Expand Up @@ -89,7 +89,7 @@ public function preSetData(FormEvent $event): void

// First remove all rows except for the prototype row
foreach ($form as $name => $child) {
$form->remove((string) $name);
$form->remove($name);
}

// Then add all rows again in the correct order
Expand Down Expand Up @@ -127,7 +127,7 @@ public function preSubmit(FormEvent $event): void

// Remove all empty rows except for the prototype row
foreach ($form as $name => $child) {
$form->remove((string) $name);
$form->remove($name);
}

// Add all additional rows
Expand Down

0 comments on commit 0898fa7

Please sign in to comment.