Restore PHP 7.3 compatibility

sonata-project · May 14, 2022 · ece658b · ece658b
1 parent 332ef76
commit ece658b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -27,6 +27,7 @@ jobs:
         strategy:
             matrix:
                 php-version:
+                    - '7.3'
                     - '7.4'
                     - '8.0'
                     - '8.1'
@@ -35,6 +36,10 @@ jobs:
                 symfony-require: ['']
                 variant: [normal]
                 include:
+                    - php-version: '7.3'
+                      dependencies: lowest
+                      allowed-to-fail: false
+                      variant: normal
                     - php-version: '7.4'
                       dependencies: lowest
                       allowed-to-fail: false

diff --git a/src/Twig/CanonicalizeRuntime.php b/src/Twig/CanonicalizeRuntime.php
@@ -26,7 +26,10 @@ final class CanonicalizeRuntime implements RuntimeExtensionInterface
         'fr' => ['fr', 'fr-ca', 'fr-ch'],
     ];
 
-    private RequestStack $requestStack;
+    /**
+     * @var RequestStack
+     */
+    private $requestStack;
 
     /**
      * @internal This class should only be used through Twig

diff --git a/tests/Twig/CanonicalizeRuntimeTest.php b/tests/Twig/CanonicalizeRuntimeTest.php
@@ -20,9 +20,15 @@
 
 final class CanonicalizeRuntimeTest extends TestCase
 {
-    private Request $request;
+    /**
+     * @var Request
+     */
+    private $request;
 
-    private CanonicalizeRuntime $canonicalizeRuntime;
+    /**
+     * @var CanonicalizeRuntime
+     */
+    private $canonicalizeRuntime;
 
     protected function setUp(): void
     {