Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apply tag instead of spaceless #107

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Use apply tag instead of spaceless #107

merged 1 commit into from
Jul 15, 2020

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Jul 15, 2020 •
edited

Subject

This removes spaceless deprecated tag.

I am targeting this branch, because this is BC.

Changelog

### Fixed
- Replace `spaceless` deprecated tag with `apply` tag and `spaceless` filter.

@franmomu franmomu added the patch label Jul 15, 2020
@phansys
Copy link
Member

phansys commented Jul 15, 2020

IMO, the changelog should use the "Fixed" section instead of "Changed", since this PR fixes the deprecated uses and its notices.

@franmomu
Copy link
Member Author

IMO, the changelog should use the "Fixed" section instead of "Changed", since this PR fixes the deprecated uses and its notices.

I had doubts, but then I thought "Fixed" were meant to something that doesn't work properly, but yeah, it fixes the notices.

@jordisala1991 jordisala1991 merged commit d79f7ff into sonata-project:1.x Jul 15, 2020
@jordisala1991
Copy link
Member

Thank you @franmomu

@franmomu franmomu deleted the fix_deprecations branch July 16, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franmomu @phansys @jordisala1991