Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove triggering deprecation when loading class #129

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Remove triggering deprecation when loading class #129

merged 1 commit into from
Sep 3, 2020

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Sep 3, 2020

Subject

When using this package, you always get:

The Sonata\Form\Type\EqualType class is deprecated since version 1.2 and will be removed in 2.0. Use Sonata\AdminBundle\Form\Type\Operator\EqualOperatorType instead.

even if you are not using the type, I removed the trigger_error call and added it to the service definition.

I am targeting this branch, because this is BC.

Changelog

### Fixed
- Fixed triggering a deprecation for EqualType only when it is used.

@franmomu franmomu added the patch label Sep 3, 2020
@greg0ire greg0ire merged commit cd81933 into sonata-project:1.x Sep 3, 2020
@greg0ire
Copy link
Contributor

greg0ire commented Sep 3, 2020

Thanks @franmomu !

@franmomu franmomu deleted the remove_trigger branch September 3, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franmomu @greg0ire @jordisala1991