Handle moment locale when request locale has equal language and country parts #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgtrescazes
force-pushed
the
fix/unhandled-moment-locales
branch
from
e08d522
to
2dbc9fc
Compare
jgtrescazes
force-pushed
the
fix/unhandled-moment-locales
branch
from
2dbc9fc
to
e2cc031
Compare
|
Can you rebase to fix the build? @jgtrescazes |
…age part and country part.
jgtrescazes
force-pushed
the
fix/unhandled-moment-locales
branch
from
e2cc031
to
b0c3525
Compare
|
@jordisala1991 done |
jordisala1991
approved these changes
Apr 29, 2023
|
Thank you @jgtrescazes , I have modified your changelog , please take a look and confirm it is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle moment locale
This PR aims to retrieve expected moment locale when request's locale includes country part like 'it-IT' or 'pl-PL'.
When this kind of locales are used in Request, sonata try to load a moment locale file that does not exists (ie: /bundles/sonataform/moment-locale/it-IT.js)
I am targeting this branch, because this is a bug fix.
Changelog