Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs, remove NEXT_MAJOR comments #433

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented May 13, 2023

Subject

I am targeting this branch, because this is a BC break.

Changelog

### Removed
- `sonata_form_canonicalize_locale_for_moment` twig function

@jordisala1991
Copy link
Member Author

I have tested on a real project, and with this change I am forced to not even mention this function name on twig files, otherwise it explodes (Even if the function call is behind an if), so the only way is to make use of the older SonataAdmin function (explained on the other PR).

@jordisala1991 jordisala1991 marked this pull request as ready for review May 13, 2023 09:08
@jordisala1991 jordisala1991 merged commit a78285d into sonata-project:2.x May 13, 2023
19 checks passed
@jordisala1991 jordisala1991 deleted the improvement/prepare-2.0 branch May 13, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants