prepend Twig form_themes config

[Hanmac]

Subject

I am targeting this branch, because is that BC or not?

Changelog

### Added
- Add datepicker twig template to the global ones

BC or not BC? or can this be done in 1.x too?

PageBundle does it too:
https://github.com/sonata-project/SonataPageBundle/blob/489e2fa48ce170b73e8bebc7ca9c10fac1d7778e/src/DependencyInjection/SonataPageExtension.php#L39

[VincentLanglet]

Does doing this allow to remove it from https://github.com/sonata-project/SonataPageBundle/blob/489e2fa48ce170b73e8bebc7ca9c10fac1d7778e/src/DependencyInjection/SonataPageExtension.php#L39 ?

[Hanmac]

Does doing this allow to remove it from https://github.com/sonata-project/SonataPageBundle/blob/489e2fa48ce170b73e8bebc7ca9c10fac1d7778e/src/DependencyInjection/SonataPageExtension.php#L39 ?

Yes, also it seems that the Page one can stop implementing the Prepend Interface

Also for BC, it doesn't cause problems if both modules try to add the template

For this MR, I think it could be done in the 1.x branch because it should be BC?

[VincentLanglet]

It seems BC to me ; wdyt @jordisala1991 ?

[Hanmac]

Also the part in the Documentation needs to be updated
But that can be done in different MR?

[Hanmac]

i think we could do, this in the 1.x branch because it should not be a BC break

then PageBundle can require that version and remove their stuff. This would be a BC break for PageBundle because it doesn't need PrependExtensionInterface anymore

[VincentLanglet]

Also the part in the Documentation needs to be updated But that can be done in different MR?

It's better to do the doc changes in the same PR which is changing the behavior

[Hanmac]

i removed the part from the Documentation about setup the twig config

[Hanmac]

i just need to know if i should rebase it against 1.x branch or not

[VincentLanglet]

i just need to know if i should rebase it against 1.x branch or not

To me yes.

[jordisala1991]

Thanks @Hanmac , after we deal with release of this pr, could you deal with the pagebundle code removal?