Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Twig Extension Tests #450

Merged
merged 5 commits into from Jul 14, 2023
Merged

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jul 11, 2023

Subject

I am targeting this branch, because Tests should be BC.

i think I'm going to add some more tests testing against real Twig-Bundle, but that will be another dev require

@Hanmac Hanmac changed the base branch from 2.x to 1.x July 12, 2023 09:33
@Hanmac Hanmac closed this Jul 12, 2023
@Hanmac Hanmac reopened this Jul 12, 2023
@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 12, 2023

@VincentLanglet @jordisala1991 do i need to try to fix CanonicalizeExtension if it got removed in the later branches?

@VincentLanglet
Copy link
Member

@VincentLanglet @jordisala1991 do i need to try to fix CanonicalizeExtension if it got removed in the later branches?

No, it's a false positive from PHPStan

@Hanmac Hanmac marked this pull request as ready for review July 14, 2023 07:15
@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 14, 2023

@VincentLanglet @jordisala1991 does this need more Tests?

i think that should work testing against fake/mock and also real Twig Extension?

I choose 1.x Branch Because i think this changes should be BC? because they are only tests?

@jordisala1991
Copy link
Member

1.x is not maintained anymore. We will only merge exceptional bugs on that branch, for the rest of stuff, better on 2.x. Can you do the change?

@Hanmac Hanmac changed the base branch from 1.x to 2.x July 14, 2023 08:33
@Hanmac
Copy link
Contributor Author

Hanmac commented Jul 14, 2023

1.x is not maintained anymore. We will only merge exceptional bugs on that branch, for the rest of stuff, better on 2.x. Can you do the change?

done

@jordisala1991 jordisala1991 merged commit f0d8083 into sonata-project:2.x Jul 14, 2023
21 checks passed
@jordisala1991
Copy link
Member

Thanks @Hanmac

@Hanmac Hanmac deleted the twigTests branch July 14, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants