New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Twig Extension Tests #450
Conversation
@VincentLanglet @jordisala1991 do i need to try to fix CanonicalizeExtension if it got removed in the later branches? |
No, it's a false positive from PHPStan |
@VincentLanglet @jordisala1991 does this need more Tests? i think that should work testing against fake/mock and also real Twig Extension? I choose 1.x Branch Because i think this changes should be BC? because they are only tests? |
1.x is not maintained anymore. We will only merge exceptional bugs on that branch, for the rest of stuff, better on 2.x. Can you do the change? |
done |
Thanks @Hanmac |
Subject
I am targeting this branch, because Tests should be BC.
i think I'm going to add some more tests testing against real Twig-Bundle, but that will be another dev require