DevKit updates for 1.x branch #170
Conversation
| @@ -3,3 +3,4 @@ | |||
| .php_cs.cache | |||
| composer.lock | |||
| phpunit.xml | |||
| /.phpunit.result.cache | |||
There was a problem hiding this comment.
Shall we add this to dev kit?
There was a problem hiding this comment.
Hmm yes I think we could manage them mostly the same. Let's see afterwards if we have some special cases and add them via an {%if ...} like for other config files, WDYT? Open to create a PR?
There was a problem hiding this comment.
So we would list other config files in projects.yml or what?
|
@OskarStark can you check PHPStan? |
I fixed the image itself, these are real errors reported by PHPStan. cc @core23 are you willing to fix them? |
To me it looks like composer deps are never installed and that's what causing the errors… |
|
The action is running: |
|
And it complains about not being able to find classes from vendors |
|
@OskarStark I have no issue locally with phpstan so I think it really is an issue the workflow (maybe there should be more steps?) |
|
@OskarStark I think it is because the image uses This is incompatible with the concept of optional dependencies we sometimes use in Sonata. |
|
@silasjoisten can you please have a look? |
|
Let's merge as is for now, but it would be great to have some solution for this. |
No description provided.