Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write prope jQuery plugin instead of generating #124

Closed
beberlei opened this issue Jun 10, 2011 · 3 comments
Closed

Write prope jQuery plugin instead of generating #124

beberlei opened this issue Jun 10, 2011 · 3 comments

Comments

@beberlei
Copy link
Contributor

The jQuery code is auto-generated currently, but it follows patterns. Additionally there is onclick="" used instead of proper jQuery event handling. This should be cleaned up alot and injecting the relevant data into the plugin using html5 data-* properties.
@rande
Copy link
Member

rande commented Jan 22, 2013

not possible so far

@rande rande closed this as completed Jan 22, 2013
@stof
Copy link
Contributor

stof commented Jan 23, 2013

@rande why wouldn't it be possible ?

@rande
Copy link
Member

rande commented Jan 23, 2013

Because some code generation are done on purpose, and rewriting it as a full independant plugin will take ages ;) so this not going to happen

tashanta pushed a commit to tashanta/SonataAdminBundle that referenced this issue Aug 5, 2013
@rande
Merge pull request sonata-project#124 from michelsalib/class_filter
c3fd475 
[WIP] Add class filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rande @beberlei @stof