Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Twig form_themes #1699

Closed
Hanmac opened this issue Jun 16, 2023 · 1 comment · Fixed by #1702
Closed

Remove Twig form_themes #1699

Hanmac opened this issue Jun 16, 2023 · 1 comment · Fixed by #1702
Labels

Comments

@Hanmac
Copy link
Contributor

Hanmac commented Jun 16, 2023

Feature Request

After sonata-project/form-extensions#444 gets into a Release,
then this can be removed:

$bundles = $container->getParameter('kernel.bundles');
\assert(\is_array($bundles));
// add custom form widgets
if ($container->hasExtension('twig')) {
if (isset($bundles['SonataFormBundle'])) {
$container->prependExtensionConfig('twig', [
'form_themes' => ['@SonataForm/Form/datepicker.html.twig'],
]);
}
}

This should be BC, and with a notice to remove the method and implements PrependExtensionInterface NEXT_MAJOR

@Hanmac Hanmac added the feature label Jun 16, 2023
@VincentLanglet
Copy link
Member

sonata-project/form-extensions#444 is released @Hanmac
In 1.20.0 and soon in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants