Auto detect lets try again #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will fix in a later commit
Parallel and tweak the logging for a bit better debugging when they fail
Basically if you dont pass in --os then we will attempt to figure it out.
bhamail
approved these changes
Aug 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soooo i tried to do auto detect in #7 and well it sat for too long. Trying to rebase was hard. So I just started over pulling certain things over that i could on top of master.
Should be in a good state i believe. Added some integration tests under the
./dockerfolder. Found that Centos 8 changed the output format ofyum list installedso thats fun. Have yet to fix that but didn't want to hold up opening this PR.It relates to the following issue #s:
cc @bhamail / @DarthHater