Bump dependencies #190
Merged
Bump dependencies #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterB0wl
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Tested and it got rid of yargs-parser just fine.
Minimist 0.0.8 is still in there as a prod dependency of node-persist:
ajurgenson@ArtieSonaDell:~/git_repos/auditjs$ npm ls minimist --production
auditjs@4.0.13 /home/ajurgenson/git_repos/auditjs
└─┬ node-persist@3.0.5
└─┬ mkdirp@0.5.1
└── minimist@0.0.8
@DarthHater filed in issue with node-persist here: simonlast/node-persist#123
Will see how responsive that team is and if not explore alternatives to remove the minimist vuln.
DarthHater
pushed a commit
that referenced
this pull request
Mar 27, 2020
## [4.0.14](v4.0.13...v4.0.14) (2020-03-27) ### Bug Fixes * Bump yargs due to yargs/yargs-parser#258 ([#190](#190)) ([69598e5](69598e5))
|
🎉 This PR is included in version 4.0.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
yargsto 15.13.1 or greater, given an upstream update toyargs-parserwhich was vulnerable to prototype pollution.Our exposure to
minimist 0.0.8is vianode-persistand throughmkdirp. I've filed an issue withnode-persistsuggesting a change that would fix the issue (quit using mkdirp, you can create a directory recursively with node natively as of 10.12 now). Issue is here: simonlast/node-persist#123This pull request makes the following changes:
yargsversion rangeIt relates to the following issue #s:
cc @bhamail / @DarthHater / @allenhsieh / @ken-duck