Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Replace yaspin (and terminaltables) with rich #77

Closed
madpah opened this issue Dec 9, 2021 · 1 comment · Fixed by #78
Closed

[FEATURE] Replace yaspin (and terminaltables) with rich #77

madpah opened this issue Dec 9, 2021 · 1 comment · Fixed by #78
Assignees
@madpah
Labels
enhancement New feature or request

Comments

@madpah
Copy link
Collaborator

madpah commented Dec 9, 2021

As part of #73, #72, it has become clear that yaspin (a direct dependency) relies upon termcolor which has no binary/wheel distribution available.

As suggested by @bollwyvl on #72, this issue is tracking replacing yaspin with rich. Given rich also supports table display, we are also planning to remove terminaltables and use rich's support for this.

cc @bhamail / @DarthHater
@madpah madpah added the enhancement New feature or request label Dec 9, 2021
@madpah madpah self-assigned this Dec 9, 2021
@madpah
Copy link
Collaborator Author

madpah commented Dec 9, 2021

Tasks:

@madpah madpah mentioned this issue Dec 9, 2021
Merged
madpah added a commit that referenced this issue Dec 13, 2021
@madpah
feat: replaced yaspin, termcolor and terminaltable with rich …
8534ad9 
…- see #72, #73, #77

Signed-off-by: Paul Horton <phorton@sonatype.com>
@madpah madpah linked a pull request Dec 13, 2021 that will close this issue
feat: removed yaspin and replaced with rich #78
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madpah madpah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: removed yaspin and replaced with rich sonatype-nexus-community/jake
1 participant
@madpah