You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What are you trying to do?
Checking for if running in a test in production code is kinda icky..... is there a refactor that can be done here so that this is not necessary??
What feature or behavior is this required for?
Nothing really.....just removing a little ickyness
How could we solve this issue? (Not knowing is okay!)
Maybe conversion to a struct or something where the log directory could be passed in easily. Or something else ¯_(ツ)_/¯
I think @bhamail had some cool thoughts here, in that maybe we can pass in a io.Writer or something akin and make it a) more easy to test (since you can pass in anything), and kinda take the log directory etc... out of it like you are suggesting.
Checking for if running in a test in production code is kinda icky..... is there a refactor that can be done here so that this is not necessary??
nancy/logger/logger.go
Line 29 in a76019e
nancy/logger/logger.go
Lines 75 to 80 in a76019e
What feature or behavior is this required for?
Nothing really.....just removing a little ickyness
How could we solve this issue? (Not knowing is okay!)
Maybe conversion to a struct or something where the log directory could be passed in easily. Or something else ¯_(ツ)_/¯
Anything else?
cc @bhamail / @DarthHater
The text was updated successfully, but these errors were encountered: