Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Integration Tests #48

Merged
merged 10 commits into from Oct 23, 2019
Merged

More Integration Tests #48

merged 10 commits into from Oct 23, 2019

Conversation

allenhsieh
Copy link
Contributor

Added 3 new ITs and their corresponding resources

This pull request makes the following changes:

  • Added tests for packagesmatcher, listmatcher, and zipballmatcher
  • populated the it-resources folder with files needed to run the new tests

It relates to the following issue #s:

@allenhsieh allenhsieh self-assigned this Oct 4, 2019
@DarthHater DarthHater changed the base branch from master to it October 4, 2019 20:27
Copy link
Member

@DarthHater DarthHater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looks good to me!

@DarthHater
Copy link
Member

@allenhsieh allenhsieh changed the base branch from it to master October 14, 2019 19:00
@allenhsieh allenhsieh changed the base branch from master to it October 14, 2019 19:02
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. One comment about the "wacky" test. Up to you if a new Issue is created and that is tackled in a new PR, or if you want to tackle it here.

@allenhsieh allenhsieh merged commit a942488 into it Oct 23, 2019
@allenhsieh allenhsieh deleted the moreit branch October 23, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants