-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Integration Tests #48
Conversation
nexus-repository-composer-it/src/test/it-resources/packages.json
Outdated
Show resolved
Hide resolved
...mposer-it/src/test/java/org/sonatype/nexus/repository/composer/internal/ComposerProxyIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments but looks good to me!
...mposer-it/src/test/java/org/sonatype/nexus/repository/composer/internal/ComposerProxyIT.java
Show resolved
Hide resolved
Build appears to be failing (https://circleci.com/gh/sonatype-nexus-community/nexus-repository-composer/9?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link), you'll want to resolve that before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. One comment about the "wacky" test. Up to you if a new Issue is created and that is tackled in a new PR, or if you want to tackle it here.
Added 3 new ITs and their corresponding resources
This pull request makes the following changes:
It relates to the following issue #s: