Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parent ID to module xml - CLM-22793 #129

Merged
merged 1 commit into from Oct 24, 2022
Merged

Add parent ID to module xml - CLM-22793 #129

merged 1 commit into from Oct 24, 2022

Conversation

mealingr
Copy link
Contributor

@mealingr mealingr commented Oct 11, 2022 •
edited

@sonatypecla
Copy link

sonatypecla bot commented Oct 11, 2022

Thanks for the contribution! Before we can merge this, we need @mealingr to sign the Sonatype Contributor License Agreement.

@guillermo-varela
Copy link
Contributor

The change looks good, when the updated version of nexus-platform-api is available at Central I'm sure CI will work.

@mealingr mealingr marked this pull request as ready for review October 24, 2022 13:46
mr-zepol
mr-zepol approved these changes Oct 24, 2022
View reviewed changes
Copy link

@mr-zepol mr-zepol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

guillermo-varela
guillermo-varela approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@guillermo-varela guillermo-varela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@guillermo-varela guillermo-varela merged commit 7a5dd18 into sonatype-nexus-community:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillermo-varela guillermo-varela guillermo-varela approved these changes

@mr-zepol mr-zepol mr-zepol approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mealingr @guillermo-varela @mr-zepol