Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets for non-jar dependencies ignore type #19

Closed
fbricon opened this issue May 17, 2018 · 1 comment · Fixed by #20
Closed

Snippets for non-jar dependencies ignore type #19

fbricon opened this issue May 17, 2018 · 1 comment · Fixed by #20

Comments

@fbricon
Copy link

fbricon commented May 17, 2018

  • What are you trying to do?
    Copy snippets for non-jar Maven dependencies

  • What feature or behavior is this required for?
    Directly pasting snippets to a pom.xml (or other build files)

  • How could we solve this issue? (Not knowing is okay!)
    Currently, all artifacts, regardless of their packaging, display dependency snippets as if they were jars.
    For instance, https://search.maven.org/beta/artifact/org.eclipse.hudson/hudson-war/3.3.3/war has a war packaging and yet you get:

<dependency>
  <groupId>org.eclipse.hudson</groupId>
  <artifactId>hudson-war</artifactId>
  <version>3.3.3</version>
</dependency>

I expect the xml snippet to be:

<dependency>
  <groupId>org.eclipse.hudson</groupId>
  <artifactId>hudson-war</artifactId>
  <version>3.3.3</version>
  <type>war</type>
</dependency>

Problem is probably the same for other build system snippets, but I mostly use Maven so I wouldn't know.

@DarthHater
Copy link
Member

DarthHater commented May 17, 2018

Should be resolved as a part of #20 , I'll let you know when we get it deployed! I only did this for Maven, as I'm not as knowledgeable on other build systems, but I can always do that if people file an issue. Thanks for getting involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants