Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding StartupProbe for long upgrade intervals #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

srini-hdp
Copy link
Collaborator

Description of Change

Added StartupProbe to handle long upgrade intervals (current setting with 2.5 hours).

Things to Do Before Submitting

  • Have you signed the Sonatype CLA?
  • Have you added and run automated tests for your change?
    (See the README)
  • Have you run helm lint on your change?

@@ -3,7 +3,7 @@ name: nexus-iq-server

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 161.0.0
version: 161.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not require any update (unless you want to publish the chart manually to artifacthub immediately). The next planned release (162) will update this line and publish the chart automatically to artifacthub.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As 162 is already released, have to perform the changes to new version now.
Would need a new chart version, like 162.0.1

Comment on lines +60 to +61
periodSeconds: 10
failureThreshold: 900
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, how was this value determined? As it is the worst case it could wait about 900 * 10 seconds, which comes to about 2 and half hours.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5 hours was taken as a guess number, which should cover 80% of the upgrade scenarios.
When following Sonatype's recommendation of using external database for our products, this time should handle 95% of cases.

When large H2 DB's are in use, during upgrades, schema changes takes long time, at times days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants