Fix imagePullSecrets fuckup #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug is still present, just hit it, took me a while to find out what was actually going wrong then found this PR. Since docker hub has rate limit, image pull secrets have become more and more important. What can we do to fix this? |
|
What I can do is close this PR because obviously the maintainers are incompetent as heck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone submits something, it's best if they actually test what they submitted.
This one is obviously not tested at all (not even
helm template .), because it fills the deployment with gibrish (a complete copy of values.yaml to be precise)A simple solution to prevent this from hapening in the future, is simply adding CI to run the chart. Though if this is supposed to be professional software, some unittests also might be relevant.