Repositions modal dialogs on screen resize

[djsauble]

Ensures that modals stick to the center of the screen, improves consistency.

Before: http://take.ms/ViKjf
After: http://take.ms/max1G

• Removes ‘x’ close icon from modal dialogs
• Extends NX.view.ModalDialog instead of Ext.window.Window
• Prevent modals from being resized
• Give NuGetAPIKey modal proper padding with the nx-inset UI style

[kellyrob99]

+1
Looks like we almost always override the dialog width, might want to minimally provide some constants for S/M/L dialogs rather than custom widths everywhere

[djsauble]

Agreed. @mhorvat-sonatype, what were the standard widths you’ve settled on for Lifecycle?

[jdillon]

+0 unsure why we care, adding a helper to reduce the modal config is good however. dont' care too much about resizing.

[djsauble]

@jdillon It’s a consistency thing. If we center a dialog, it should remain centered until it’s closed.

Also, Lifecycle behaves this way, so it’s a win-win.

[mcculls]

+1

[jdillon]

it still odd ux, since the dialog is movable, it will change positions on resize. IIRC CLM dialogs are not movable, so works better for them. Though immovable dialogs is also pretty annoying.

[djsauble]

@jdillon Hmmm… why do the dialogs need to be movable?

[djsauble]

Centering change reverted per sprint review feedback.

b40b653