Fix Content-Range header

[ahirata]

According to the HTTP spec, a Content-Range header must start with "bytes " when using bytes as the range unit.

Some refs:

• RFC
• nginx
• apache
• docker

[ahirata]

Just to add some context, in my case, an error may occur when trying to pull a docker image from nexus:

Feb 01 21:27:53 user dockerd[4156]: time="2017-02-01T21:27:53.020840206Z" level=error msg="Download failed, retrying: could not parse Content-Range header: 1085508104-1143481246/1143481247"

[DarthHater]

Hey @ahirata thanks for this. We are going to start taking a look at it internally soon.

Secondly, can you fill out a CLA, sign, scan all pages and send it to me: jhesse at sonatype dot com

http://www.sonatype.org/SonatypeCLA.pdf

Once we have that I'll try and get some more eyes on this and get it merged down.

[padresmurfa]

I've also just encountered a problem due to this. "https://github.com/eclipse/aether-core/blob/master/aether-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java" fails to pull from nexus due to a malformed Content-Range response header from Nexus.

As far as I can tell, the HttpTransporter is implemented correctly according to RFC 2616, section 14.16 (Content-Range), while the PartialFetchHandler is not.

Btw. the link to the CLA is broken @DarthHater .

According to RFC 7233, there is actually also the possibility of non-byte based ranges, but I doubt that would come into play here.

[ahirata]

I have completely forgotten about this PR. I'm sorry @DarthHater :(

@padresmurfa The issue this PR addresses is now fixed on master. I guess if you're still having problems using the most recent version you should open a new issue.

[padresmurfa]

Thanks a lot, @ahirata, I can see that now. It looks like the fix was added about 4 months ago.

Odds are that I'm not using the most recent version, as this is an enterprise environment. I'll assume that I can get this fixed simply by getting the IT department to upgrade the server.