Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy API request converter for http client auth #63

Conversation

jonesbusy
Copy link

Authentication is part of of HTTP client configuration, not connection settings.

Creating/Updating proxy with authentication via the REST API ignore the settings.

@jonesbusy
Copy link
Author

CLA signed

@jonesbusy jonesbusy force-pushed the bugfix/fix-proxy-repo-api-converter-for-http-auth branch from a5d7baa to e175220 Compare February 28, 2020 21:00
Copy link

@dawidsawa dawidsawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing find, thank you for your contribution!

@jonesbusy
Copy link
Author

Thanks @dawidsawa! I started to migrate our Nexus3 configuration as code from groovy API to REST and found this :)

@jonesbusy jonesbusy force-pushed the bugfix/fix-proxy-repo-api-converter-for-http-auth branch from e175220 to cf62579 Compare March 9, 2020 12:58
@dawidsawa
Copy link

@jonesbusy we were not able to merge this PR to our master branch. There's a conflict, that git was able to auto-resolve, but one test suite is failing: MavenApiResourceIT. Until this is fixed we need to put it on hold.

@demian711
Copy link

Hello. Same issue here. Any milestone for this to be merged? Thanks

@i-cz
Copy link

i-cz commented Apr 24, 2020

I am desperatelly waiting for this fix to be merged. When is it going to be ?

@acelorio
Copy link

Hi. Any updates on when this could be merged? Now that Groovy scripts are disabled by default, the REST interface has become the preferred way to interact with Nexus. Thanks!

@dawidsawa
Copy link

Hi. We decided to move this fix in-house and it's being worked on track it as NEXUS-23872 so it will be included in our next release, likely 3.24.0

@dawidsawa dawidsawa closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants