Fix edge cases for classnames (no namespace)

sonatype · Apr 8, 2013 · 979a64f · 979a64f
1 parent b826164
commit 979a64f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/nexus-webapp/src/main/webapp/js/NX/base.js b/nexus-webapp/src/main/webapp/js/NX/base.js
@@ -46,12 +46,14 @@ define('NX/base', ['require'], function(require) {
        */
       obj: function (path) {
           var context = NX.global;
-          Ext.each(path.split('.'), function (part) {
-              context = context[part];
-              if (context === undefined) {
-                  throw new Error('No object at path: ' + path + '; part is undefined: ' + part);
-              }
-          });
+          if (typeof path === 'string') {
+            Ext.each(path.split('.'), function (part) {
+                context = context[part];
+                if (context === undefined) {
+                    throw new Error('No object at path: ' + path + '; part is undefined: ' + part);
+                }
+            });
+          }
           return context;
       },
 

diff --git a/nexus-webapp/src/main/webapp/js/lib/string.js b/nexus-webapp/src/main/webapp/js/lib/string.js
@@ -35,7 +35,9 @@ Ext.applyIf(String.prototype, {
             intIndexOfMatch = strText.indexOf(strTarget);
         }
 
-        return (strText);
+        // return new String, because returning "this" here without a #replace inbetween returns a char array,
+        // not a String (seen in chrome).
+        return String(strText);
     }
 });